Drop Resque\Logger class #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danhunsaker
approved these changes
Apr 28, 2024
This removes the internal PSR-3 logger. Now, if no custom logger is set up in the APP_INCLUDE, logging is disabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the internal PSR-3 logger. Now, if no custom logger is set up in the APP_INCLUDE, logging is disabled.
I think by now everyone is using PSR-3 and there's no need to continue shipping our own logger. Dropping it allows us to support a wider range of
psr/log, which provides projects the freedom to choose the best version for them. Should also help a bit with PHP 8 compatibility (since latest monolog no longer supports PHP 7)